CDN - Add Geofencing #994
CDN - Add Geofencing #994
Conversation
|
@matheuspolitano Could you please add a description to the PR which describes what you want to implement here? |
rubenhoenle
added
has internal tracking issue
needs-work
|
And I would kindly ask you to squash your commits into some meaningful ones. Having these 26 commits makes not much sense to me. |
|
On hold until #983 is merged. |
|
@matheuspolitano Could you please resolve the conflicts? :) |
matheuspolitano
force-pushed
the
mp/cdn-add-geofencing
branch
from
df477c5 to
af17e1c
Compare
Co-authored-by: Marcel Jacek <[email protected]>
Co-authored-by: Marcel Jacek <[email protected]>
Co-authored-by: Marcel Jacek <[email protected]>
Co-authored-by: Marcel Jacek <[email protected]>
| // convertPointerSliceToStringSlice safely converts a slice of string pointers to a slice of strings. | ||
| func convertPointerSliceToStringSlice(pointerSlice []*string) []string { | ||
| if pointerSlice == nil { | ||
| return nil // Or []string{} depending on how you want to handle it | ||
| } | ||
| stringSlice := make([]string, 0, len(pointerSlice)) | ||
| for _, strPtr := range pointerSlice { | ||
| if strPtr != nil { // Safely skip any nil pointers in the list | ||
| stringSlice = append(stringSlice, *strPtr) | ||
| } | ||
| } | ||
| return stringSlice | ||
| } |
There was a problem hiding this comment.
Can you move this to the utils package and add a few tests for this function? This is a function we probably need in some other places as well.
| oldCountriesPtrs := oldGeofencingMap[url] | ||
|
|
||
| oldCountries := convertPointerSliceToStringSlice(oldCountriesPtrs) |
There was a problem hiding this comment.
it could be the case, that the old map might doesn't have the url, e.g. if someone extended the geofencing values via the api directly. So you need to check here, if the oldMap has the url key and if not, it must be handled correctly
| geofencingCountry := make([]string, len(countryCodes)) | ||
| for i, countryCodePtr := range countryCodes { | ||
| if countryCodePtr == nil { | ||
| continue |
There was a problem hiding this comment.
If an url has only one country code and this one is set to null, it will result in an api error, because the URL would have an empty array. So I would return here an error instead of continue
| countryStrings := make([]string, len(countries)) | ||
| for i, countryPtr := range countries { | ||
| if countryPtr != nil { | ||
| countryStrings[i] = *countryPtr | ||
| } | ||
| } |
There was a problem hiding this comment.
You should return here an error, if coutryPtr is nil to prevent api issues. This could happen if someone sets null within the country list and then an empty array will be send to the api
Description
https://jira.schwarz/browse/STACKITCDN-875
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)